- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Workaround max name limit imposed by Jackson 2.17 #126806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates elastic#58952
| 
           Hi @rjernst, I've created a changelog YAML for you.  | 
    
| 
           Pinging @elastic/es-core-infra (Team:Core/Infra)  | 
    
              
                    mosche
  
              
              approved these changes
              
                  
                    Apr 15, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
    
  rjernst 
      added a commit
        to rjernst/elasticsearch
      that referenced
      this pull request
    
      Apr 15, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates elastic#58952
    
  rjernst 
      added a commit
        to rjernst/elasticsearch
      that referenced
      this pull request
    
      Apr 15, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates elastic#58952
    
  rjernst 
      added a commit
        to rjernst/elasticsearch
      that referenced
      this pull request
    
      Apr 15, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates elastic#58952
  This was referenced Apr 15, 2025 
      
    
  rjernst 
      added a commit
        to rjernst/elasticsearch
      that referenced
      this pull request
    
      Apr 15, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates elastic#58952
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Apr 15, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates #58952
    
  afoucret 
      pushed a commit
        to afoucret/elasticsearch
      that referenced
      this pull request
    
      Apr 16, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates elastic#58952
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Apr 18, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates #58952 Co-authored-by: Elastic Machine <[email protected]>
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Apr 19, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates #58952 Co-authored-by: Elastic Machine <[email protected]>
    
  elasticsearchmachine 
      pushed a commit
      that referenced
      this pull request
    
      Apr 19, 2025 
    
    
      
  
    
      
    
  
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates #58952 Co-authored-by: Elastic Machine <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    auto-backport
  Automatically create backport pull requests when merged 
  
    >bug
  
    :Core/Infra/Core
  Core issues without another label 
  
    Team:Core/Infra
  Meta label for core/infra team 
  
    v8.17.6
  
    v8.18.1
  
    v8.19.0
  
    v9.0.1
  
    v9.1.0
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited.
relates #58952